Skip to content

TYP: Add type definition for generators in excel.py #45139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2022
Merged

TYP: Add type definition for generators in excel.py #45139

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f31e081
TYP: define gen and gen2 as Iterable
Dec 31, 2021
61630ee
Merge remote-tracking branch 'upstream/master' into fix_mypy_err_exce…
Jan 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions pandas/io/formats/excel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,20 +649,21 @@ def _format_header_regular(self) -> Iterable[ExcelCell]:
)

def _format_header(self) -> Iterable[ExcelCell]:
gen: Iterable[ExcelCell]

if isinstance(self.columns, MultiIndex):
gen = self._format_header_mi()
else:
gen = self._format_header_regular()

gen2 = ()
gen2: Iterable[ExcelCell] = ()

if self.df.index.names:
row = [x if x is not None else "" for x in self.df.index.names] + [
""
] * len(self.columns)
if reduce(lambda x, y: x and y, map(lambda x: x != "", row)):
# error: Incompatible types in assignment (expression has type
# "Generator[ExcelCell, None, None]", variable has type "Tuple[]")
gen2 = ( # type: ignore[assignment]
gen2 = (
ExcelCell(self.rowcounter, colindex, val, self.header_style)
for colindex, val in enumerate(row)
)
Expand Down