PERF: find_stack_level #45247
Merged
PERF: find_stack_level #45247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm happy to take your word for it. |
|
@mroeschke good here? |
mroeschke
approved these changes
Jan 7, 2022
|
thanks @lithomas1 |
|
wouldn't object to backport ing this |
3 tasks
|
@meeseeksdev backport 1.4.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Apr 27, 2022
jreback
pushed a commit
that referenced
this pull request
Apr 27, 2022
Co-authored-by: Thomas Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some low hanging fruit in find_stack_level.
pytest pandas/tests/groupby/test_function.py -v -k "test_builtins_apply"goes from 35 -> 6 secs for me.Someone may want to verify. Also IDK how to benchmark this.
@jbrockmendel Would you like to test this locally to verify the perf gains?