Skip to content

Conversation

datapythonista
Copy link
Member

The way we are calling asv in the CI is too complex for no reason. Removing the next unnecessary things:

  • asv check not worth calling, since just imports the benchmarks which will be later imported anyway when calling asv run
  • Adding the remote to git doesn't have any effect I think, since we don't specify the commit, and we should be running benchmarks for what's been checked out
  • asv machine is not useful, since we won't save the results, or compare them with other runs
  • asv dev just avoids creating environments, but we can speed up things a bit by just running each benchmark once, and not save the results, which are not used anyway
  • The conditional to just run the benchmarks if the previous step build is successful, is the default. It makes sense in other parts of this file, since there are several steps depending on a build, but not in this case
  • I don't think publishing the asv log makes a lot of sense. I think I added that myself in the past, but now feels just a waste of time and resources (unless someone used that artifact, then please let me know)

I'm going to see how to remove the hacky grep and just leave the asv call, but I think this needs a new asv release.

@datapythonista datapythonista added CI Continuous Integration Benchmark Performance (ASV) benchmarks labels Apr 1, 2022
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Related, It would also be nice for the failing lines in benchmark.log to be echo/cat-ed to make it easier to pinpoint which benchmarks failed.

@jreback jreback added this to the 1.5 milestone Apr 3, 2022
@jreback jreback merged commit 0bec088 into pandas-dev:main Apr 3, 2022
@jreback
Copy link
Contributor

jreback commented Apr 3, 2022

thanks @datapythonista

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Benchmark Performance (ASV) benchmarks CI Continuous Integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants