Skip to content

Added improvements in to_datetime Error reporting message #47995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 16, 2022
Merged

Added improvements in to_datetime Error reporting message #47995

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b5ac0be
#16757: improvement of to_datetime errors
dannyi96 Aug 6, 2022
082a8eb
Merge branch 'main' into todatetime_err_imp
dannyi96 Aug 12, 2022
9b6c357
The exceptions from to_datetime(errors='raise') could include informa…
dannyi96 Aug 12, 2022
a396048
Merge branch 'main' into todatetime_err_imp
dannyi96 Aug 15, 2022
ad10821
testcase updates
dannyi96 Aug 15, 2022
c3bbb4f
testcase updates
dannyi96 Aug 15, 2022
ca3c9a4
testcase updates
dannyi96 Aug 16, 2022
d4f53a4
Merge branch 'main' into todatetime_err_imp
dannyi96 Aug 16, 2022
7bc3367
testcase updates
dannyi96 Aug 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pandas/_libs/tslib.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,7 +595,7 @@ cpdef array_to_datetime(
continue
elif is_raise:
raise ValueError(
f"time data {val} doesn't match format specified"
f"time data \"{val}\" at position {i} doesn't match format specified"
)
return values, tz_out

Expand All @@ -607,11 +607,11 @@ cpdef array_to_datetime(
# to check if all arguments have the same tzinfo
tz = py_dt.utcoffset()

except (ValueError, OverflowError):
except (ValueError, OverflowError) as err:
if is_coerce:
iresult[i] = NPY_NAT
continue
raise TypeError("invalid string coercion to datetime")
raise type(err)(f"invalid string coercion to datetime for \"{val}\" at position {i}")

if tz is not None:
seen_datetime_offset = True
Expand Down