REGR: fix reset_index (Index.insert) regression with custom Index subclasses #48058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
added
Regression
3 tasks
simonjayhawkins
approved these changes
Aug 22, 2022
This comment was marked as resolved.
This comment was marked as resolved.
simonjayhawkins
pushed a commit
to simonjayhawkins/pandas
that referenced
this pull request
Aug 22, 2022
…gression with custom Index subclasses
phofl
pushed a commit
that referenced
this pull request
Aug 22, 2022
…rt) regression with custom Index subclasses) (#48199) Backport PR #48058: REGR: fix reset_index (Index.insert) regression with custom Index subclasses Co-authored-by: Joris Van den Bossche <[email protected]>
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.I added a new test file with a minimal custom Index subclass, as I don't know if it can otherwise be tested with out own indexes (and added a new file since I didn't find existing tests for Index subclasses)