Revert "PERF: faster corrwith method for pearson and spearman correlation when other is a Series and axis = 0 (column-wise) (#46174)" #49140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
force-pushed
the
revert-5efb570
branch
from
b545bf2 to
b03b76e
Compare
…tion when other is a Series and axis = 0 (column-wise) (pandas-dev#46174)" This reverts commit 5efb570.
MarcoGorelli
force-pushed
the
revert-5efb570
branch
from
4abc10a to
b6bd617
Compare
Closed
added 2 commits
October 17, 2022 10:25
mroeschke
added
the
Algos
mroeschke
approved these changes
Oct 17, 2022
|
Thanks @MarcoGorelli |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Oct 17, 2022
…r pearson and spearman correlation when other is a Series and axis = 0 (column-wise) (pandas-dev#46174)"
5 tasks
MarcoGorelli
added a commit
that referenced
this pull request
Oct 17, 2022
…hod for pearson and spearman correlation when other is a Series and axis = 0 (column-wise) (#46174)") (#49151) Backport PR #49140: Revert "PERF: faster corrwith method for pearson and spearman correlation when other is a Series and axis = 0 (column-wise) (#46174)" Co-authored-by: Marco Edward Gorelli <[email protected]>
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
…tion when other is a Series and axis = 0 (column-wise) (pandas-dev#46174)" (pandas-dev#49140) * Update frame.py * Revert "PERF: faster corrwith method for pearson and spearman correlation when other is a Series and axis = 0 (column-wise) (pandas-dev#46174)" This reverts commit 5efb570. * fix GH issue number in test * add test from original issue * skip if no scipy * add extra test case Co-authored-by: Yuanhao Geng <[email protected]> Co-authored-by: MarcoGorelli <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataFrame.corrwithis changed in pandas 1.5.0 ?? #48826 (Replace xxxx with the GitHub issue number)Seriesis changed? #49141doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Reverting for now - I've a test fix and whatsnew note from #49032 , but have reverted the change and added the issue as a test so we can go ahead with 1.5.1. A fixed version of the performance improvement can go into 2.0.0