Skip to content

Conversation

rhshadrach
Copy link
Member

@rhshadrach rhshadrach commented Oct 20, 2022

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Noticed this after #49162 was merged. Likely makes very little difference unless values is huge.

@rhshadrach rhshadrach added Performance Memory or execution speed performance Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff labels Oct 20, 2022
@rhshadrach rhshadrach requested a review from phofl October 20, 2022 03:11
@phofl phofl added this to the 2.0 milestone Oct 20, 2022
@phofl phofl merged commit 14b2b61 into pandas-dev:main Oct 20, 2022
@phofl
Copy link
Member

phofl commented Oct 20, 2022

thx @rhshadrach

@rhshadrach rhshadrach deleted the isin_perf_followup branch October 20, 2022 10:41
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Performance Memory or execution speed performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants