Skip to content

Conversation

MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Jan 12, 2023

#48911

Backport PR #49386

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@simonjayhawkins
Copy link
Member

@MarcoGorelli do you need to move release note also?

@MarcoGorelli
Copy link
Member Author

I'm not sure the original PR should have had a release note TBH if it was just a documentation change, I'd be inclined to just remove it from there

@simonjayhawkins
Copy link
Member

I'd be inclined to just remove it from there

sgtm

@MarcoGorelli MarcoGorelli added this to the 1.5.3 milestone Jan 12, 2023
@MarcoGorelli MarcoGorelli merged commit d4062f8 into pandas-dev:1.5.x Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants