Skip to content

CLN: Put exit_stack inside _query_iterator. #51125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2023
Merged

CLN: Put exit_stack inside _query_iterator. #51125

merged 1 commit into from
Feb 3, 2023

Conversation

cdcadman
Copy link
Contributor

@cdcadman cdcadman commented Feb 2, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

This closes up a follow up item from the pull request #49967 .

@mroeschke mroeschke added IO SQL to_sql, read_sql, read_sql_query Clean labels Feb 2, 2023
@mroeschke mroeschke added this to the 2.0 milestone Feb 3, 2023
@mroeschke mroeschke merged commit 1539aed into pandas-dev:main Feb 3, 2023
@mroeschke
Copy link
Member

Thanks @cdcadman

@cdcadman cdcadman deleted the query_iterator branch February 9, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees

No one assigned

Labels

Clean IO SQL to_sql, read_sql, read_sql_query

Projects

None yet

Milestone

2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@cdcadman @mroeschke