Skip to content

Conversation

phofl
Copy link
Member

@phofl phofl commented Feb 25, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@datapythonista

I think #50897 broke the blog-redirects. This works locally.

@phofl phofl added the Web pandas website label Feb 25, 2023
@datapythonista
Copy link
Member

Ups, not sure how I missed this.

It's a bit more complex. We've got two different kinds of posts, the ones in our website, and the ones in other blogs. The ones in our own blog are currently working, the broken ones are the ones in other blogs (like your blog or mine). Your changes makes the external posts work, but it breaks the ones we write in our own blog/website. I opened #51649 with the fix that works for both (I thought it was faster/easier to open a new PR than comment here, I hope you don't mind).

@phofl
Copy link
Member Author

phofl commented Feb 26, 2023

Ah makes sense. Did not think about our own blog. Thx for noticing.

Yeah no worries, closing here then

@phofl phofl closed this Feb 26, 2023
@phofl phofl deleted the web branch February 26, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Web pandas website

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants