Skip to content

Conversation

lithomas1
Copy link
Contributor

@lithomas1 lithomas1 commented Jun 7, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@mroeschke
Looks like you disabled this in #47057, but it seems to work fine at least for the non-MI index case.
Did you only mean to disable multiple labels for the MI case? Just wanted to make sure I'm not missing anything.

@lithomas1 lithomas1 requested a review from rhshadrach as a code owner June 7, 2023 16:30
@mroeschke mroeschke added the numba numba-accelerated operations label Jun 7, 2023
@mroeschke mroeschke added this to the 2.1 milestone Jun 7, 2023
@mroeschke mroeschke merged commit 4e83066 into pandas-dev:main Jun 7, 2023
@mroeschke
Copy link
Member

Nice catch thanks @lithomas1. I think this was an oversight on my part back then

@lithomas1 lithomas1 deleted the numba-multilabel branch June 7, 2023 22:23
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
* ENH: Numba groupby support multiple labels

* update regex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

numba numba-accelerated operations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants