Skip to content

Conversation

lithomas1
Copy link
Contributor

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@lithomas1 lithomas1 added this to the 2.1.2 milestone Oct 10, 2023
@lithomas1 lithomas1 added CI Continuous Integration Python 3.12 labels Oct 10, 2023
@lithomas1 lithomas1 modified the milestones: 2.1.2, 2.1.3 Oct 25, 2023
@alimcmaster1
Copy link
Member

Ref: #53665

Thanks for doing this @lithomas1 - shout if you want any help.

DeprecationWarning: Bitwise inversion '~' on bool is deprecated. This returns the bitwise inversion of the underlying int object and is usually not what you expect from negating a bool. Use the 'not' operator for boolean negation or ~int(x) if you really want the bitwise inversion of the underlying int.

^ Saw this in a few places in the test failures.

@jorisvandenbossche jorisvandenbossche modified the milestones: 2.1.3, 2.1.4 Nov 13, 2023
@lithomas1
Copy link
Contributor Author

Sorry for the lack of updates. Closing in favor of #56174.

@lithomas1 lithomas1 closed this Nov 26, 2023
@lithomas1 lithomas1 removed this from the 2.1.4 milestone Nov 26, 2023
@lithomas1 lithomas1 deleted the py312-testing branch March 16, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous Integration Python 3.12

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants