Skip to content

Conversation

dannyi96
Copy link
Contributor

@dannyi96 dannyi96 commented Nov 12, 2023

Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks could you add a whatsnew entry in v2.1.4.rst?

@mroeschke mroeschke added the Apply Apply, Aggregate, Transform, Map label Nov 13, 2023
@dannyi96
Copy link
Contributor Author

done, updated the whatsnew

@mroeschke mroeschke added this to the 2.1.4 milestone Nov 14, 2023
@mroeschke mroeschke merged commit 19bbe06 into pandas-dev:2.1.x Nov 14, 2023
@mroeschke
Copy link
Member

Thanks @dannyi96

@dannyi96 dannyi96 deleted the 2.1_55753_fix branch November 14, 2023 17:45
@lithomas1
Copy link
Contributor

I think we needed to move the whatsnew from 2.2.0 to 2.1.3, since there's an existing whatsnew already from the original PR that fixed this.

@dannyi96 Interested in doing another PR against main fixing this?

@dannyi96
Copy link
Contributor Author

sure @lithomas1.
do you mean removing the related whatsnew in v2.2.0.rst since its already been added in v2.1.3.rst ( & hence not a new fix in 2.2.0) ?

@lithomas1
Copy link
Contributor

You need to move it since your changes only applied to 2.1.x not main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Apply Apply, Aggregate, Transform, Map

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants