Skip to content

BUG: Fix empty MultiIndex DataFrame xlsx export #57697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 2, 2024
Merged

BUG: Fix empty MultiIndex DataFrame xlsx export #57697

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bcfef0
BUG: Fix empty MultiIndex DataFrame xlsx export (#57696)
speleo3 Mar 1, 2024
94fb184
Address @rhshadrach review comments
speleo3 Mar 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/source/whatsnew/v3.0.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,7 @@ MultiIndex

I/O
^^^
- Bug in :class:`io.formats.excel.ExcelFormatter` when writing empty :class:`DataFrame` with :class:`MultiIndex` on both axes (:issue:`57696`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe ExcelFormatter is private; can you change to to :meth:`DataFrame.to_excel`

-
-

Expand Down
2 changes: 1 addition & 1 deletion pandas/io/formats/excel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,7 +620,7 @@ def _format_header_mi(self) -> Iterable[ExcelCell]:
lnum = 0

if self.index and isinstance(self.df.index, MultiIndex):
coloffset = len(self.df.index[0]) - 1
coloffset = self.df.index.nlevels - 1

if self.merge_cells:
# Format multi-index as a merged cells.
Expand Down
11 changes: 11 additions & 0 deletions pandas/tests/io/excel/test_writers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -936,6 +936,17 @@ def test_to_excel_empty_multiindex(self, tmp_excel):
result, expected, check_index_type=False, check_dtype=False
)

def test_to_excel_empty_multiindex_both_axes(self, tmp_excel):
# GH 57696
df = DataFrame(
[],
index=MultiIndex.from_tuples([], names=[0, 1]),
columns=MultiIndex.from_tuples([("A", "B")]),
)
df.to_excel(tmp_excel)
result = pd.read_excel(tmp_excel, header=None)
assert result.iloc[:2, -1].to_list() == ["A", "B"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you test the entire result? I think if you change the read line to

result = pd.read_excel("tmp.xlsx", header=[0, 1], index_col=[0, 1])

Then you should just be able to do

tm.assert_frame_equal(result, df)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, that looks better and works exactly like you said.


def test_to_excel_float_format(self, tmp_excel):
df = DataFrame(
[[0.123456, 0.234567, 0.567567], [12.32112, 123123.2, 321321.2]],
Expand Down