Skip to content

API/CoW: take view of underlying Block values for shallow (deep=False) copies #58966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

API/CoW: take view of underlying Block values for shallow (deep=False) copies #58966

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68af237
API/CoW: take view of underlying Block values for shallow (deep=False…
jorisvandenbossche Jun 10, 2024
e45e423
use self instead of shallow copy for inplace operations
jorisvandenbossche Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pandas/core/internals/blocks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,16 +651,16 @@ def copy(self, deep: bool = True) -> Self:
values = values.copy()
refs = None
else:
values = values.view()
refs = self.refs
return type(self)(values, placement=self._mgr_locs, ndim=self.ndim, refs=refs)

# ---------------------------------------------------------------------
# Copy-on-Write Helpers

def _maybe_copy(self, inplace: bool) -> Self:
if inplace:
deep = self.refs.has_reference()
return self.copy(deep=deep)
if inplace and not self.refs.has_reference():
return self
return self.copy()

@final
Expand Down