Skip to content

DOC: Fix for excelwriter engine for ods files #59185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2024
Merged

DOC: Fix for excelwriter engine for ods files #59185

merged 1 commit into from
Jul 5, 2024

Conversation

asishm
Copy link
Member

@asishm asishm commented Jul 5, 2024

From #58831 (comment)

Changing odswriter references to odfpy

from pandas.io.excel._util import get_writer
get_writer('odswriter') # fails with ValueError: No Excel writer 'odswriter'
get_writer('odf') # works returning pandas.io.excel._odswriter.ODSWriter

That said, the library doesn't seem to be maintained. Maybe we should consider deprecating.

@asishm asishm requested a review from rhshadrach as a code owner July 5, 2024 09:23
@mroeschke mroeschke added Docs IO Excel read_excel, to_excel labels Jul 5, 2024
@mroeschke mroeschke added this to the 3.0 milestone Jul 5, 2024
@mroeschke mroeschke merged commit e3af7c6 into pandas-dev:main Jul 5, 2024
@mroeschke
Copy link
Member

Thanks @asishm

That said, the library doesn't seem to be maintained. Maybe we should consider deprecating.

I would be +1 for that

@asishm asishm deleted the excel_odf_doc branch July 6, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mroeschke mroeschke mroeschke approved these changes

@rhshadrach rhshadrach Awaiting requested review from rhshadrach rhshadrach is a code owner

Assignees

No one assigned

Labels

Docs IO Excel read_excel, to_excel

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@asishm @mroeschke