-
-
Notifications
You must be signed in to change notification settings - Fork 18.8k
DOC: Added extra sentences to clarify series.GroupBy snippets in examples #59331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Added extra sentences to clarify series.GroupBy snippets in examples #59331
Conversation
can you check your pr again please? something's gone wrong |
Hello marco, i am trying to understand what went wrong in this pr, and am in the middle of my research. I was about to ask for guidance on the issue tracker soon if I could not figure it out. However, I will ask for guidance now itself as I have not made progress. Timeline: First I made changes to the documentation as specified in the issue, however i noticed that the tests kept falling over with errors related to numpy and dataframe mismatches. Look at the commit here To verify that the error is related to my changes, I deleted all the changes I made and synced it up with main branch and it passed. Commit here I believed that I wrote the documentation changes incorrectly, however, I tested if the tests fail even with a small change and the tests still fell over. Commit Here My conclusion now is that it is just not happy if I make even the smallest changes to the documentation and thus I need to make changes somewhere else to give me permissions to allow me to make changes to the main area of documentation. I was trying to find instructions on it but haven't been able to find anything. Could you provide guidance as to where I am going wrong? Or should I go on Stack Overflow instead? |
check https://github.com/pandas-dev/pandas/pull/59331/files and see if it looks right |
there may have been some test failures unrelated to your, you shouldn't worry about them |
Okay I have pushed all the changes I think should be made according to the suggestions made in the issue. |
Thanks @ApoorvApoorv |
You're welcome! Just one question, is it okay to delete the branch now? I could not find guidance on whether I should or not? |
Yes it's OK to delete the branch |
Uh oh!
There was an error while loading. Please reload this page.