Skip to content

DOC: Improve sort parameter doc of DataFrameGroupBy.value_counts #59412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

DOC: Improve sort parameter doc of DataFrameGroupBy.value_counts #59412

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ccb1c84
change sort parameter of DataFrameGroupBy.value_counts
KevsterAmp Aug 5, 2024
b77066f
remove sort parameter doc change on SeriesGroupby.value_counts
KevsterAmp Aug 5, 2024
37fcea4
modify sort parameter doc change in DataFrameGroupby.value_counts
KevsterAmp Aug 5, 2024
ea33198
revert sort parameter doc of SeriesGroupBy.value_counts
KevsterAmp Aug 5, 2024
ca574c9
Merge branch 'main' into improve-DataFrameGroupBy-value_counts-sort-p…
mroeschke Aug 5, 2024
056ddba
Merge remote-tracking branch 'upstream/main' into improve-DataFrameGr…
KevsterAmp Aug 6, 2024
900f653
improve sort parameter doc of SeriesGroupBy.value_counts
KevsterAmp Aug 6, 2024
6e5fe2d
Merge branch 'main' into improve-DataFrameGroupBy-value_counts-sort-p…
KevsterAmp Aug 11, 2024
7d28d96
update SeriesGroupBy.value_counts sort doc
KevsterAmp Aug 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pandas/core/groupby/generic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,7 +746,7 @@ def value_counts(
normalize : bool, default False
Return proportions rather than frequencies.
sort : bool, default True
Sort by frequencies.
Sort by frequencies when True. Preserve the order of the data when False.
ascending : bool, default False
Sort in ascending order.
bins : int or list of ints, optional
Expand Down Expand Up @@ -2303,7 +2303,7 @@ def value_counts(
normalize : bool, default False
Return proportions rather than frequencies.
sort : bool, default True
Sort by frequencies.
Sort by frequencies when True. Sort by DataFrame column values when False.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also want to modify the docstring on SeriesGroupBy.value_counts. Can you make the same adjustment there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing

ascending : bool, default False
Sort in ascending order.
dropna : bool, default True
Expand Down