Skip to content

BUG: Series[python_str].__setitem__(series[pyarrow_string] #52987 #59534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

BUG: Series[python_str].__setitem__(series[pyarrow_string] #52987 #59534

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1b83cae
52987 - removed if condition converting to array unconditionally in l…
Tharun-PS Aug 17, 2024
0aec535
reverted back changes in main branch
Tharun-PS Aug 17, 2024
08da38c
52987 - removed if condition converting to array unconditionally in l…
Tharun-PS Aug 17, 2024
68f3fc1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions pandas/core/arrays/string_.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
register_extension_dtype,
)
from pandas.core.dtypes.common import (
is_array_like,
is_bool_dtype,
is_integer_dtype,
is_object_dtype,
Expand Down Expand Up @@ -686,8 +685,7 @@ def __setitem__(self, key, value) -> None:
f"Cannot set non-string value '{value}' into a StringArray."
)
else:
if not is_array_like(value):
value = np.asarray(value, dtype=object)
value = np.asarray(value, dtype=object)
if len(value) and not lib.is_string_array(value, skipna=True):
raise TypeError("Must provide strings.")

Expand Down