String dtype: remove fallback Perfomance warnings for string methods #59760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
approved these changes
Sep 9, 2024
|
My preference would be a simple Boolean show all vs show none (ref: #55385 (comment)). In any case, showing warnings when the user has no viable path of better performance doesn't seem appropriate. This looks good to me. |
…-fallback-perf-warnings
|
OK, sounds good, let's then simply remove those for now. |
jorisvandenbossche
deleted the
string-dtype-remove-fallback-perf-warnings
branch
jorisvandenbossche
added a commit
to jorisvandenbossche/pandas
that referenced
this pull request
Oct 10, 2024
jorisvandenbossche
added a commit
that referenced
this pull request
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #58581
The current PR simply removes the warning altogether, but now we have the
"mode.performance_warnings"option, we could in theory also keep the warnings as long as they are not enabled by default.However, the performance warnings option right now is still on by default. So if we want to do this right now (keep the string fallback warnings but not enabled by default), we would need to change that default to something like
Nonewhich then means True/False depending on the case .. (cc @rhshadrach)xref #54792