BUG: avoid triggering numpy deprecation warning in assert functions for nested array with empty array/list

[jorisvandenbossche]

I haven't added a whatsnew note, because it shouldn't change behaviour but just avoids a warning being triggered (so thought that to not warrant a mention in the release notes)

• closes BUG: assert_frame_equal triggers DeprecationWarning with column with empty lists/arrays #59776
• Tests added and passed if fixing a bug or adding a new feature
• All code checks passed.
• Added type annotations to new arguments/methods/functions.
• Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

[jorisvandenbossche]

Below we would essentially do bool(left == right) which raises an error for arrays/lists of size > 1 (and that error would then be caught below, turned into return False. So for now, just directly returning False here when left or right is a numpy array and the other not.

That then avoids doing this bool(left == right) for empty array/list case, which triggers the warning.

[WillAyd]

So for now, just directly returning False here when left or right is a numpy array and the other not.

Did you mean to use xor instead of or?

[jorisvandenbossche]

The first if just before is if PyArray_Check(x) and PyArray_Check(y), so the or is sufficient

[lithomas1]

Does this need a backport?

[jorisvandenbossche]

No, it's just for silencing a warning in a corner case, not worth of backporting