Skip to content

BUG: Remove np._get_promotion_state usage #59818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 16, 2024
Merged

BUG: Remove np._get_promotion_state usage #59818

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aadb59c
BUG: Remove np._get_promotion_state usage
lysnikolaou Sep 16, 2024
4fcf438
Add NPY_PROMOTION_STATE env variable back
lysnikolaou Sep 16, 2024
85e756b
Use NPY_PROMOTION_STATE environment variable
lysnikolaou Sep 16, 2024
5150301
Mark test as xfail on WASM
lysnikolaou Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions pandas/tests/series/indexing/test_setitem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
from pandas._config import using_string_dtype

from pandas.compat import HAS_PYARROW
from pandas.compat.numpy import np_version_gte1p24
from pandas.errors import IndexingError

from pandas.core.dtypes.common import is_list_like
Expand Down Expand Up @@ -1444,10 +1443,6 @@ def obj(self):
np.float32,
False,
marks=pytest.mark.xfail(
(
not np_version_gte1p24
or (np_version_gte1p24 and np._get_promotion_state() != "weak")
),
reason="np.float32(1.1) ends up as 1.100000023841858, so "
"np_can_hold_element raises and we cast to float64",
),
Expand Down
Loading