Skip to content

ENH: Improve error mesage verbosity in string accessor #59900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 28, 2024
Merged

ENH: Improve error mesage verbosity in string accessor #59900

Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
99b1c3d
sync to master
KevsterAmp Sep 7, 2024
55e6e47
Merge remote-tracking branch 'upstream/main'
KevsterAmp Sep 7, 2024
912293a
Merge remote-tracking branch 'upstream/main'
KevsterAmp Sep 26, 2024
9107624
improve error verbosity
KevsterAmp Sep 26, 2024
9ef9fe8
Merge remote-tracking branch 'upstream/main' into verbose-error-msg
KevsterAmp Oct 22, 2024
c6cb4b9
remove "!" on the error message
KevsterAmp Oct 22, 2024
a616b29
match exact error message on test
KevsterAmp Oct 24, 2024
d482efe
Merge remote-tracking branch 'upstream/main' into verbose-error-msg
KevsterAmp Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pandas/core/strings/accessor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,9 @@ def _validate(data):
inferred_dtype = lib.infer_dtype(values, skipna=True)

if inferred_dtype not in allowed_types:
raise AttributeError("Can only use .str accessor with string values!")
raise AttributeError(
f"Can only use .str accessor with string values!, not {inferred_dtype}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the !, I believe it is not grammatically correct.

)
return inferred_dtype

def __getitem__(self, key):
Expand Down
Loading