Skip to content

Conversation

wshaoul
Copy link

@wshaoul wshaoul commented Oct 5, 2024

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@mroeschke
Copy link
Member

Thanks for the PR, but it's unclear what this PR addresses. I would recommend opening a PR in your own repo first if practicing the contributing flow so closing

@mroeschke mroeschke closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants