Fix: Change None values to NaN in combine_first method for better handling of missing data #59987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dling of missing data
Lavishgangwani
changed the title
|
Thanks for the PR but it appears this PR has gone stale and requires unit tests and a whatsnew entry. Closing but feel to reopen a new pull request if interested in continuing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses issue #58977 by improving the handling of missing data in the
combine_firstmethod. The changes ensure thatNonevalues are replaced withNaN, which allows for better integration with other Pandas functions that expectNaNvalues.Related Issue
Series.combine_firstreplacesNonewithNaNat index not provided byother#58977Checklist