Skip to content

Conversation

easternsun7
Copy link
Contributor

The problem is "DOC: Intro to pandas table not readily visible in dark mode #60024"
Perhaps we could set this part of the font color to blue, which is highly visible in either bright or dark mode, so that there is no need to implement a font color that changes with the theme.
So I made a very simple change in the documentation by setting the font color in .tutorial-card-header-2 to blue so that the font can be seen in either bright or dark mode.

The problem is "DOC: Intro to pandas table not readily visible in dark mode pandas-dev#60024"
Perhaps we could set this part of the font color to blue, which is highly visible in either bright or dark mode, so that there is no need to implement a font color that changes with the theme.
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems preferable to me to agree with other versions of this page. Both dev and 2.1 display correctly, it's just 2.2 that does not. Why is this? Could it be a regression in the pydata-sphinx-theme that has since been fixed?

@easternsun7
Copy link
Contributor Author

It seems preferable to me to agree with other versions of this page. Both dev and 2.1 display correctly, it's just 2.2 that does not. Why is this? Could it be a regression in the pydata-sphinx-theme that has since been fixed?

I noticed that both Dev and 2.2 are built with PyData-Sphinx-theme 0.14.4, so maybe something else is wrong.
The issue raised on the PyData-Sphinx-theme's github didn't have anyone raise the same issue as the pandas 2.2 version, so maybe we can wait until the new version is released and see what happens.

@easternsun7 easternsun7 mentioned this pull request Oct 15, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants