Skip to content

DOC: fix SA01 for pandas.core.resample.Resampler.ohlc #60036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 21, 2024
Merged

DOC: fix SA01 for pandas.core.resample.Resampler.ohlc #60036

merged 2 commits into from
Oct 21, 2024

Conversation

tuhinsharma121
Copy link
Contributor

@tuhinsharma121 tuhinsharma121 commented Oct 14, 2024 •
edited
Loading

fixes

pandas.core.resample.Resampler.ohlc SA01
pandas.core.groupby.DataFrameGroupBy.ohlc SA01
pandas.core.groupby.SeriesGroupBy.ohlc SA01

@tuhinsharma121 tuhinsharma121 marked this pull request as ready for review October 14, 2024 09:53
rhshadrach
rhshadrach approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach added this to the 3.0 milestone Oct 21, 2024
@rhshadrach rhshadrach merged commit 68d9dca into pandas-dev:main Oct 21, 2024
58 of 59 checks passed
lfffkh pushed a commit to lfffkh/pandas that referenced this pull request Oct 28, 2024
@tuhinsharma121 @lfffkh
DOC: fix SA01 for pandas.core.resample.Resampler.ohlc (pandas-dev#60036)
1cc94c2
lfffkh added a commit to lfffkh/pandas that referenced this pull request Oct 28, 2024
@lfffkh
Revert "DOC: fix SA01 for pandas.core.resample.Resampler.ohlc (pandas…
a81875a 
…-dev#60036)"

This reverts commit 1cc94c2.
@tuhinsharma121 tuhinsharma121 deleted the pandas.core.resample.Resampler.ohlc branch October 29, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhshadrach rhshadrach rhshadrach approved these changes

@mroeschke mroeschke Awaiting requested review from mroeschke mroeschke is a code owner

Assignees

No one assigned

Labels

Docs Groupby Resample resample method

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@tuhinsharma121 @rhshadrach