FIX: Resolve KeyError with LaTeX headers in to_latex method #60077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed an issue with LaTeX headers by preventing format interpretation in style_render.py. - Added test cases to validate proper handling of LaTeX headers without index columns.
timapage
force-pushed
the
fix-latex-keyerror
branch
from
b8ca0db to
1517662
Compare
|
This is not a sensible fix. It is a hard coded direct string replacement for the exact issue presented. What about the flip case where the user actually wants to display what they have input and don't expect it to be directly replaced by your fix? I will take a look at the underlying issue but I am not entirely convinced it even warrants a fix yet. |
|
Yeah you are right. I did not consider this case. Thank you for your feedback. |
|
Appears it may be too early to submit a PR at this point so closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to_latex()does not handle braces in new headers gracefully #60063doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.