Skip to content

BUG: Convert output type in Excel for MultiIndex with period levels #60182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Nov 22, 2024
Merged

BUG: Convert output type in Excel for MultiIndex with period levels #60182

merged 17 commits into from
Nov 22, 2024

Conversation

ZKaoChi
Copy link
Contributor

@ZKaoChi ZKaoChi commented Nov 4, 2024 •
edited
Loading

rhshadrach
rhshadrach requested changes Nov 6, 2024
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Please add tests whenever changing functionality.

@rhshadrach rhshadrach changed the title Convert output type in Excel for PeriodIndex in Index or MultiIndex b… BUG: Convert output type in Excel for MultiIndex with period levels Nov 6, 2024
@rhshadrach rhshadrach added Bug IO Excel read_excel, to_excel labels Nov 6, 2024
@ZKaoChi ZKaoChi requested a review from mroeschke as a code owner November 9, 2024 08:24
rhshadrach
rhshadrach requested changes Nov 10, 2024
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - can you also add one test in excel/test_writers.py for round-tripping (writes a DataFrame to an excel file, reads it, and asserts its the same as the original DataFrame).

rhshadrach
rhshadrach requested changes Nov 11, 2024
View reviewed changes
@ZKaoChi
Copy link
Contributor Author

ZKaoChi commented Nov 12, 2024 •
edited
Loading

Looking good - can you also add one test in excel/test_writers.py for round-tripping (writes a DataFrame to an excel file, reads it, and asserts its the same as the original DataFrame).

My test case gets called 8 times, 6 times the dtype of result is 'datetime64[us]', and the other two times is 'datetime64[s]'. I don't know why this is happening. I had to do unit conversions for result.

@ZKaoChi
Copy link
Contributor Author

ZKaoChi commented Nov 13, 2024

Looking good - can you also add one test in excel/test_writers.py for round-tripping (writes a DataFrame to an excel file, reads it, and asserts its the same as the original DataFrame).

My test case gets called 8 times, 6 times the dtype of result is 'datetime64[us]', and the other two times is 'datetime64[s]'. I don't know why this is happening. I had to do unit conversions for result.

I've found that the dtype of result depends on the suffix of tmp_excel, only in the case of .ods the dtype is datetime64[s] and in other cases it is datetime64[us]. The latest PR has been completed by changing the expected to match result, please check it out. Thanks a lot!!!

@ZKaoChi
Copy link
Contributor Author

ZKaoChi commented Nov 13, 2024

And maybe it can be a new issue to unify the units of datetime in different tmp_excel formats.

yuanx749
yuanx749 reviewed Nov 17, 2024
View reviewed changes
rhshadrach
rhshadrach requested changes Nov 17, 2024
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a note in the whatsnew for v3.0.0 under the I/O section.

@ZKaoChi
Copy link
Contributor Author

ZKaoChi commented Nov 17, 2024

Can you add a note in the whatsnew for v3.0.0 under the I/O section.

Sure.

@ZKaoChi
Copy link
Contributor Author

ZKaoChi commented Nov 21, 2024

@rhshadrach I'm sorry for the trouble, but could you please let me know if there is anything else to change? Thank you very much!

mroeschke
mroeschke reviewed Nov 21, 2024
View reviewed changes
mroeschke
mroeschke reviewed Nov 21, 2024
View reviewed changes
@mroeschke mroeschke requested a review from rhshadrach November 22, 2024 18:58
@mroeschke mroeschke added this to the 3.0 milestone Nov 22, 2024
rhshadrach
rhshadrach approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach added Period Period data type MultiIndex labels Nov 22, 2024
@rhshadrach rhshadrach merged commit ee0902a into pandas-dev:main Nov 22, 2024
57 of 59 checks passed
@rhshadrach
Copy link
Member

Thanks @ZKaoChi!

@ZKaoChi
Copy link
Contributor Author

ZKaoChi commented Nov 25, 2024

Thanks a lot for all your help!

KevsterAmp pushed a commit to KevsterAmp/pandas that referenced this pull request Mar 12, 2025
@ZKaoChi @KevsterAmp
BUG: Convert output type in Excel for MultiIndex with period levels (p…
6b8e6a9 
…andas-dev#60182)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mroeschke mroeschke mroeschke approved these changes

@rhshadrach rhshadrach rhshadrach approved these changes

+1 more reviewer

@yuanx749 yuanx749 yuanx749 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Bug IO Excel read_excel, to_excel MultiIndex Period Period data type

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

BUG: Inconsistent output type in Excel for PeriodIndex in Index or MultiIndex

4 participants

@ZKaoChi @rhshadrach @mroeschke @yuanx749