Skip to content

TST (string dtype): avoid hardcoded object dtype for columns in datetime_frame fixture #60192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2024
Merged

TST (string dtype): avoid hardcoded object dtype for columns in datetime_frame fixture #60192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9148698
TST (string dtype): avoid hardcoded object dtype for columns in datet…
jorisvandenbossche Nov 5, 2024
7c5dec3
remove unnecessary xfails
jorisvandenbossche Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas/tests/frame/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def datetime_frame() -> DataFrame:
"""
return DataFrame(
np.random.default_rng(2).standard_normal((10, 4)),
columns=Index(list("ABCD"), dtype=object),
columns=Index(list("ABCD")),
index=date_range("2000-01-01", periods=10, freq="B"),
)

Expand Down
1 change: 0 additions & 1 deletion pandas/tests/frame/indexing/test_indexing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,6 @@ def test_getitem_boolean(self, mixed_float_frame, mixed_int_frame, datetime_fram
if bif[c].dtype != bifw[c].dtype:
assert bif[c].dtype == df[c].dtype

@pytest.mark.xfail(using_string_dtype(), reason="TODO(infer_string)")
def test_getitem_boolean_casting(self, datetime_frame):
# don't upcast if we don't need to
df = datetime_frame.copy()
Expand Down
2 changes: 0 additions & 2 deletions pandas/tests/frame/methods/test_to_csv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ def test_to_csv_from_csv1(self, temp_file, float_frame):
float_frame.to_csv(path, header=False)
float_frame.to_csv(path, index=False)

@pytest.mark.xfail(using_string_dtype(), reason="TODO(infer_string)")
def test_to_csv_from_csv1_datetime(self, temp_file, datetime_frame):
path = str(temp_file)
# test roundtrip
Expand Down Expand Up @@ -549,7 +548,6 @@ def test_to_csv_headers(self, temp_file):
assert return_value is None
tm.assert_frame_equal(to_df, recons)

@pytest.mark.xfail(using_string_dtype(), reason="TODO(infer_string)")
def test_to_csv_multiindex(self, temp_file, float_frame, datetime_frame):
frame = float_frame
old_index = frame.index
Expand Down
Loading