Skip to content

ENH: Set __module__ on StringDtype #60261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 11, 2024
Merged

ENH: Set __module__ on StringDtype #60261

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ab2817c
fix the string datatype
espoirMur Nov 9, 2024
7e4e60a
remove .env
espoirMur Nov 9, 2024
b1986fc
fix the import error
espoirMur Nov 9, 2024
374fed8
fix failed test
espoirMur Nov 9, 2024
be69547
Update string_.py
espoirMur Nov 9, 2024
9e125e3
apply ruff
espoirMur Nov 9, 2024
44155ac
remove the module on basestring
espoirMur Nov 9, 2024
1f2fb54
Update string_.py
espoirMur Nov 9, 2024
9dba8f2
fix stuff
espoirMur Nov 9, 2024
996db1f
Update string_.py
espoirMur Nov 9, 2024
2c032bd
Merge branch 'main' into man-group/set-module-stringdtype
jorisvandenbossche Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pandas/core/arrays/string_.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,10 @@
pa_version_under10p1,
)
from pandas.compat.numpy import function as nv
from pandas.util._decorators import doc
from pandas.util._decorators import (
doc,
set_module,
)
from pandas.util._exceptions import find_stack_level

from pandas.core.dtypes.base import (
Expand Down Expand Up @@ -86,6 +89,7 @@
from pandas import Series


@set_module("pandas")
@register_extension_dtype
class StringDtype(StorageExtensionDtype):
"""
Expand Down
1 change: 1 addition & 0 deletions pandas/tests/api/test_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,3 +416,4 @@ def test_set_module():
assert pd.Period.__module__ == "pandas"
assert pd.Timestamp.__module__ == "pandas"
assert pd.Timedelta.__module__ == "pandas"
assert pd.StringDtype.__module__ == "pandas"