Skip to content

Conversation

patricktokeeffe
Copy link
Contributor

Existing pandas.core.format.CSVFormatter param quotechar can now be
specified as keyword arg to DataFrame.to_csv

@patricktokeeffe
Copy link
Contributor Author

Do I need to worry about creating test(s) for this since it's passing through to an existing parameter of pandas.core.format.CSVFormatter?

@patricktokeeffe
Copy link
Contributor Author

Yikes. Travis says it broke. I follow the failed test listed in the traceback (test_get_components_dax in pandas.io.tests.test_data.TestYahoo) through to the assert statement, including downloading the target file manually. If it's the same file I retrieved, the assert should succeed. I don't see to_csv calls anywhere so I'm at a loss so far as to what's wrong here.

@jreback
Copy link
Contributor

jreback commented Jan 22, 2014

you can force travis to rebuild that particular test (I saw that fail yesterday too...weird...but seems ok...so maybe a flaky test)

you should model some tests like other quoting type characters (prob in test_format.py or io/tests/test_parser.py).

yes write to a temp handle, then read back in and compare

@jtratner
Copy link
Contributor

It def requires a bit of care, for some reason that part is fragile

@jreback
Copy link
Contributor

jreback commented Jan 23, 2014

does this have an associated issue?

@patricktokeeffe
Copy link
Contributor Author

Most probably not--I did not file one.

Existing `pandas.core.format.CSVFormatter` param `quotechar` can now be
specified as keyword arg to `DataFrame.to_csv`
@patricktokeeffe
Copy link
Contributor Author

Closing, see #5414 sorry for the noise.

@patricktokeeffe patricktokeeffe deleted the to_csv-quotechar branch January 31, 2014 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants