Relax meson pins in CI and Fix Missed Warnings #60681
Conversation
| requires = [ | ||
| "meson-python>=0.13.1", | ||
| "meson>=1.2.1,<2", | ||
| "meson>=1.2.1", |
There was a problem hiding this comment.
I removed the <2 as I didn't want to repeat it everywhere in our CI configurations, and we don't create upper bounds like this on any other dependency. There also is not a meson 2.0 under development
There was a problem hiding this comment.
It took us ten years to get to 1.0, yeah :) no hurry to release 2.0 but whenever it does come around you can most likely expect it will only break backwards compatibility for things that have printed deprecation warnings for several years + the meson provided by Debian oldstable is new enough to support the newer approach.
|
Ah so I guess the pinned versions here were suppressing compiler errors in some fashion. Looks like #60674 will need to happen before this |
WillAyd
force-pushed
the
remove-meson-pins
branch
from
06481f0 to
348cb4d
Compare
WillAyd
force-pushed
the
remove-meson-pins
branch
2 times, most recently
from
41c2b59 to
3e200a6
Compare
| before-build = "PACKAGE_DIR={package} bash {package}/scripts/cibw_before_build.sh" | ||
|
|
||
| [tool.cibuildwheel.macos] | ||
| environment = {LDFLAGS="-Wl,--strip-all"} |
There was a problem hiding this comment.
These flags are not applicable on windows and were causing the linker to throw an error when combined with -Werror in our CI
|
I believe the remaining issues appeared with meson-python 0.16.0. Reported upstream in mesonbuild/meson-python#716 May need to put an upper limit on the 0.15.0 release for now |
WillAyd
force-pushed
the
remove-meson-pins
branch
from
c370100 to
8d6d29c
Compare
|
The pyarrow failure here is unrelated |
WillAyd
force-pushed
the
remove-meson-pins
branch
from
4136fa9 to
69e7400
Compare
WillAyd
changed the title
WillAyd
force-pushed
the
remove-meson-pins
branch
4 times, most recently
from
3ab5090 to
4ecfec0
Compare
This reverts commit 8d6d29c.
WillAyd
force-pushed
the
remove-meson-pins
branch
from
4ecfec0 to
1271d6e
Compare
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
Not actively working on this - let's clear the queue |
2 participants
Back in #60089 we relaxed the meson pin in our pyproject, but all of our CI still hard codes the minimum version. This updates it to treat the meson dependencies the same way as Cython, i.e. newer versions are used in CI