Skip to content

Conversation

BAnSsal
Copy link

@BAnSsal BAnSsal commented Jan 18, 2025

Adjusted the condition to set name = 0 only when name is explicitly None.
Previously, the name attribute was being overwritten unconditionally when ignore_index=True, even if a valid name existed.

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. When changing any behavior, please always add tests.

@rhshadrach rhshadrach added the Reshaping Concat, Merge/Join, Stack/Unstack, Explode label Feb 8, 2025
@mroeschke
Copy link
Member

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

@mroeschke mroeschke closed this Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reshaping Concat, Merge/Join, Stack/Unstack, Explode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: Concatenating dataframe and series with ignore_index = True drops the series name

3 participants