Skip to content

TST: Add test for exceptional behavior when calling view() on BaseStringArray #60799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 27, 2025
Merged

TST: Add test for exceptional behavior when calling view() on BaseStringArray #60799

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84d7c1f
add test for when str array raises type error
MattePalte Jan 27, 2025
7b312ae
fix formatting: ruff-format
MattePalte Jan 27, 2025
660803c
moved test to tests/arrays/string_/test_string.py file
MattePalte Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pandas/tests/indexes/test_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1351,6 +1351,13 @@ def test_index_round(self, decimals, expected_results):

tm.assert_index_equal(result, expected)

def test_string_array_view_type_error(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this to pandas/tests/arrays/string_/test_string.py?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks for the fast feedback @mroeschke I did move it as suggested, let me know if any other change is needed

arr = pd.array(["a", "b", "c"], dtype="string")
with pytest.raises(
TypeError, match="Cannot change data-type for string array."
):
arr.view("i8")


class TestMixedIntIndex:
# Mostly the tests from common.py for which the results differ
Expand Down
Loading