Skip to content

Conversation

tqa236
Copy link
Contributor

@tqa236 tqa236 commented Feb 6, 2025

The original reasoning to disable this rule is because getattr is needed to side step mypy, but mypy doesn't complain about the fix anymore.

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@tqa236 tqa236 requested a review from attack68 as a code owner February 6, 2025 07:42
@mroeschke mroeschke added the Code Style Code style, linting, code_checks label Feb 6, 2025
@mroeschke mroeschke added this to the 3.0 milestone Feb 6, 2025
@mroeschke mroeschke merged commit 86c2668 into pandas-dev:main Feb 6, 2025
37 of 46 checks passed
@mroeschke
Copy link
Member

Thanks @tqa236

@tqa236 tqa236 deleted the enable-b009 branch February 6, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code Style Code style, linting, code_checks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants