Bug cov nat #60898
Merged
Bug cov nat #60898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fbourgey
commented
Feb 9, 2025
fbourgey
commented
- closes BUG: cov buggy when having NaT in column #53115
WillAyd
reviewed
Feb 14, 2025
WillAyd
added
Datetime
|
@jbrockmendel, @WillAyd, could you please take a look? |
WillAyd
approved these changes
May 15, 2025
|
@jbrockmendel, I made the updates |
mroeschke
reviewed
May 21, 2025
pandas/core/frame.py
Outdated
Comment on lines
11356
to
11357
| dtypes = [blk.dtype for blk in self._mgr.blocks] | ||
| if any(d.kind in "mM" for d in dtypes): |
There was a problem hiding this comment.
Suggested change
| dtypes = [blk.dtype for blk in self._mgr.blocks] | |
| if any(d.kind in "mM" for d in dtypes): | |
| if any(blk.dtype.kind in "mM" for blk in self._mgr.blocks): |
mroeschke
reviewed
May 21, 2025
mroeschke
reviewed
May 22, 2025
mroeschke
reviewed
May 22, 2025
| ], | ||
| } | ||
| ) | ||
| arr = np.array( |
There was a problem hiding this comment.
Suggested change
| arr = np.array( | |
| expected = np.array( |
mroeschke
reviewed
May 22, 2025
| [np.nan, 8.64e04, 2.00e00], | ||
| ] | ||
| ) | ||
| assert np.allclose(df.to_numpy(float, na_value=np.nan), arr, equal_nan=True) |
There was a problem hiding this comment.
Suggested change
| assert np.allclose(df.to_numpy(float, na_value=np.nan), arr, equal_nan=True) | |
| result = df.to_numpy(float, na_value=np.nan), | |
| tm.assert_numpy_array_equal(result, expected) |
mroeschke
approved these changes
May 23, 2025
|
Thanks @fbourgey |
|
@fbourgey could you make a follow up PR adding release notes to the 3.0 whatsnew? I think this is being called a bug fix, and not an API breaking change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.