Update describe.py #60986
Closed
Update describe.py #60986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the condition where it checks if 0.5 not in the given value.
Closed
rhshadrach
requested changes
Mar 1, 2025
5 tasks
|
Thanks for the PR, but #61158 has addressed and closed the original issue so closing this PR. Happy to have your contributions towards other PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where passing a single value to .describe(percentiles=[...]) would incorrectly include the 50th percentile (median) in the output. The fix ensures that only the explicitly requested percentiles are returned.
Changes:
Modified the .describe() method to avoid adding the 50th percentile by default when a custom percentiles list is provided.
Closes: #60550