BUG: Fix na_position type in IndexEngine #61062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Mar 6, 2025
mroeschke
reviewed
Mar 6, 2025
Co-authored-by: Matthew Roeschke <[email protected]>
avm19
force-pushed
the
fix-index-na-position-128
branch
from
73725c8 to
61525c2
Compare
|
Perhaps I should not have rebased. The changes suggested above by @mroeschke are the only changes, I promise. |
mroeschke
approved these changes
Mar 7, 2025
|
Thanks @avm19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I modified an existing test to cover the problematic case)
(Stubs check fails locally for seemingly unrelated reasons. Passed on GH Actions.)
(Not applicable)
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.