Skip to content

BUG: fix bug in str.fullmatch for Arrow backend with optional groups #61073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 21, 2025
Merged

BUG: fix bug in str.fullmatch for Arrow backend with optional groups #61073

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
519ea79
Update _arrow_string_mixins.py
ptth222 Mar 7, 2025
93ad579
Updated _arrow_string_mixins.py
ptth222 Sep 15, 2025
f99bcd7
Update test_arrow.py
ptth222 Sep 16, 2025
46cb440
Update test_arrow.py
ptth222 Sep 16, 2025
cd1ebce
Update test_arrow.py
ptth222 Sep 16, 2025
c8d6048
Update test_arrow.py
ptth222 Sep 17, 2025
0796834
Update test_arrow.py
ptth222 Sep 17, 2025
26f64dd
Merge remote-tracking branch 'upstream/main' into patch-1
jorisvandenbossche Sep 21, 2025
70e82b1
remove missing value in extra test
jorisvandenbossche Sep 21, 2025
c424093
move test comparing with python to test_find_replace.py
jorisvandenbossche Sep 21, 2025
cb6a9d2
add test case with optional groups
jorisvandenbossche Sep 21, 2025
6fd088d
add whatsnew
jorisvandenbossche Sep 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions pandas/core/arrays/_arrow_string_mixins.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,8 +321,12 @@ def _str_fullmatch(
flags: int = 0,
na: Scalar | lib.NoDefault = lib.no_default,
):
if not pat.endswith("$") or pat.endswith("\\$"):
pat = f"{pat}$"
if not pat.endswith("$") and not pat.startswith("^"):
pat = f"^({pat})$"
elif not pat.endswith("$"):
pat = f"^({pat[1:]})$"
elif not pat.startswith("^"):
pat = f"^({pat[0:-1]})$"
return self._str_match(pat, case, flags, na)

def _str_find(self, sub: str, start: int = 0, end: int | None = None):
Expand Down
Loading