ENH: Support Series[bool] as indexer for iloc.__getitem__
#61162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurlw
changed the title
iloc.__getitem__
arthurlw
changed the title
iloc.__getitem__iloc.__getitem__
arthurlw
changed the title
iloc.__getitem__iloc.__getitem__
rhshadrach
reviewed
Mar 29, 2025
Member
rhshadrach
left a comment
rhshadrach
left a comment
There was a problem hiding this comment.
Thanks for the PR! Am I correct that none of the tests being modified here actually call .iloc successfully?
pandas/tests/indexing/test_iloc.py
Outdated
| mask = (df.nums > 2).values | ||
| if idx: | ||
| mask_index = getattr(df, idx)[::-1] | ||
| mask_index = getattr(df, idx if idx == "index" else "locs")[::-1] |
Member
There was a problem hiding this comment.
Since idx is not None here, I think this can be reverted.
pandas/tests/indexing/test_iloc.py
Outdated
Comment on lines
779
to
782
| except ( | ||
| ValueError, | ||
| IndexingError, | ||
| ) as err: |
Member
There was a problem hiding this comment.
nit: Can you collapse this back to one line
rhshadrach
added
Enhancement
Indexing
Member
Author
|
Hi! The test on lines 742-743 calls result = df.iloc[np.array([True] * len(mask), dtype=bool)]
tm.assert_frame_equal(result, df)I noticed I should add another test with false values so I have done so. result2 = df.iloc[np.array([True, False, True, False, True], dtype=bool)]
tm.assert_frame_equal(result2, DataFrame({"a": [0, 2, 4]}, index=["A", "C", "E"])) |
Member
Author
|
While reviewing this, I realized my tests address That being said the new tests improve coverage for |
arthurlw
changed the title
iloc.__getitem__Series[bool] as indexer for iloc.__getitem__
rhshadrach
approved these changes
Apr 8, 2025
Member
rhshadrach
left a comment
rhshadrach
left a comment
There was a problem hiding this comment.
lgtm; @mroeschke - could I get your eye here as well.
mroeschke
reviewed
Apr 8, 2025
pandas/tests/indexing/test_iloc.py
Outdated
Comment on lines
745
to
763
| result = df.iloc[np.array([True, False, True, False, True], dtype=bool)] | ||
| tm.assert_frame_equal( | ||
| result, DataFrame({"a": [0, 2, 4]}, index=["A", "C", "E"]) | ||
| ) | ||
|
|
||
| # series (index does not match) | ||
| msg = "Unalignable boolean Series provided as indexer" | ||
| with pytest.raises(IndexingError, match=msg): | ||
| df.iloc[Series([True] * len(mask), dtype=bool)] | ||
|
|
||
| df = DataFrame(list(range(5)), columns=["a"]) | ||
|
|
||
| result = df.iloc[Series([True] * len(mask), dtype=bool)] | ||
| tm.assert_frame_equal(result, df) | ||
|
|
||
| result = df.iloc[Series([True, False, True, False, True], dtype=bool)] | ||
| tm.assert_frame_equal(result, DataFrame({"a": [0, 2, 4]}, index=[0, 2, 4])) | ||
|
|
||
| df = DataFrame(list(range(5)), index=list("ABCDE"), columns=["a"]) |
Member
There was a problem hiding this comment.
Could you make each of these assertions a separate test function?
mroeschke
approved these changes
Apr 9, 2025
Member
|
Thanks @arthurlw |
snitish
pushed a commit
to snitish/pandas
that referenced
this pull request
Jun 9, 2025
…-dev#61162) * updated indexing.py to allow iloc.__getitem__ * Updated test_iloc_mask test * bugfix test_iloc_mask test * bugfix test_iloc_mask * whatsnew * added test to test_iloc_mask * formatting * precommit * added tests for series bool mask * precommit * reformatted tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ilocwithSeriesas indexer fails for__getitem__but works with__setitem__#60994doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.