Skip to content

BUG: Handle overlapping line and bar on the same plot #61173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Apr 18, 2025
Merged

BUG: Handle overlapping line and bar on the same plot #61173

Changes from 2 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
3caf8e6
Handle line and box on the same plot
MartinBraquet Mar 24, 2025
97d0440
Handle line and box on the same plot
MartinBraquet Mar 24, 2025
5fb6172
Refactor PeriodConverter to separate frequency handling.
MartinBraquet Apr 7, 2025
ee183d7
Refactor time series plotting logic in Matplotlib backend.
MartinBraquet Apr 7, 2025
e5b4e6f
Add test for bar and line plot superposition with same x values
MartinBraquet Apr 7, 2025
c5a6554
Merge branch 'main' into plot
MartinBraquet Apr 7, 2025
218871d
Fix alignment issue in Series.plot with line and bar.
MartinBraquet Apr 7, 2025
16762b6
Refactor time series handling in matplotlib plotting.
MartinBraquet Apr 7, 2025
bb2fdd7
Merge branch 'main' into plot
MartinBraquet Apr 7, 2025
950441b
Merge branch 'main' into plot
MartinBraquet Apr 8, 2025
392d2b5
Merge branch 'main' into plot
MartinBraquet Apr 9, 2025
b28f9af
Update doc/source/whatsnew/v3.0.0.rst
MartinBraquet Apr 9, 2025
7a30ec7
Apply suggestions from code review
MartinBraquet Apr 9, 2025
8d8d17d
Merge branch 'main' into plot
MartinBraquet Apr 14, 2025
168b271
Merge remote-tracking branch 'origin/plot' into plot
MartinBraquet Apr 14, 2025
8ed678d
Fix bar and line plot alignment and x-axis visibility in tests
MartinBraquet Apr 14, 2025
5cc8c28
Ensure bar_xticks length matches index in test_series.py
MartinBraquet Apr 14, 2025
6d990d4
Merge branch 'main' into plot
MartinBraquet Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions pandas/plotting/_matplotlib/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,10 @@

from pandas.io.formats.printing import pprint_thing
from pandas.plotting._matplotlib import tools
from pandas.plotting._matplotlib.converter import register_pandas_matplotlib_converters
from pandas.plotting._matplotlib.converter import (
PeriodConverter,
register_pandas_matplotlib_converters,
)
from pandas.plotting._matplotlib.groupby import reconstruct_data_with_by
from pandas.plotting._matplotlib.misc import unpack_single_str_list
from pandas.plotting._matplotlib.style import get_standard_colors
Expand Down Expand Up @@ -1855,7 +1858,6 @@ def __init__(
self.bar_width = width
self._align = align
self._position = position
self.tick_pos = np.arange(len(data))

if is_list_like(bottom):
bottom = np.array(bottom)
Expand All @@ -1868,6 +1870,14 @@ def __init__(

MPLPlot.__init__(self, data, **kwargs)

if isinstance(data.index, ABCPeriodIndex):
self.ax.freq = data.index.freq
self.tick_pos = np.array(
PeriodConverter.convert(data.index._mpl_repr(), None, self.ax)
)
else:
self.tick_pos = np.arange(len(data))

@cache_readonly
def ax_pos(self) -> np.ndarray:
return self.tick_pos - self.tickoffset
Expand Down