Skip to content

Conversation

arthurlw
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@arthurlw arthurlw requested a review from rhshadrach as a code owner April 25, 2025 00:46
@mroeschke mroeschke added the Window rolling, ewma, expanding label Apr 25, 2025
@mroeschke mroeschke added this to the 3.0 milestone Apr 25, 2025
@mroeschke mroeschke merged commit 0fce6b4 into pandas-dev:main Apr 25, 2025
46 checks passed
@mroeschke
Copy link
Member

Thanks @arthurlw

Comment on lines -3816 to -3817
Arguments are the same as `:meth:DataFrame.rolling` except that ``step`` cannot
be specified.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't rolling accept many more arguments, e.g. window?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened #61361 just to be sure this doesn't get forgotten.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was incorrect, the signature is fine here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Window rolling, ewma, expanding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants