BLD: Decrease size of docker image #61430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combining RUN commands to minimise the number of layers and cleaning up the apt lists to reduce total size.
mroeschke
reviewed
May 12, 2025
Dockerfile
Outdated
Comment on lines
4
to
8
| RUN apt-get update && \ | ||
| apt-get -y upgrade && \ | ||
| rm -rf /var/lib/apt/lists/* | ||
|
|
||
| # hdf5 needed for pytables installation | ||
| # libgles2-mesa needed for pytest-qt | ||
| RUN apt-get install -y libhdf5-dev libgles2-mesa-dev | ||
| RUN apt-get update && apt-get install -y \ |
There was a problem hiding this comment.
- Can you combine these two installs?
- Can you include
--no-install-recommends?
There was a problem hiding this comment.
Yes, done. That saves another ~0.16 Gb.
Do note that the --no-install-recommends could impact 'downstream' images based on this image, if they depend on having a recommended library installed.
Combine upgrade and install steps Add --no-install-recommends option
mroeschke
approved these changes
May 12, 2025
|
Thanks @huisman |
xaris96
pushed a commit
to xaris96/pandas
that referenced
this pull request
May 30, 2025
* Decrease size of docker image Combining RUN commands to minimise the number of layers and cleaning up the apt lists to reduce total size. * Combine upgrade and install steps Combine upgrade and install steps Add --no-install-recommends option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the size of the docker image by:
In my tests it reduced the size of the final image with approximately 0.47GB (most of it due to the --no-cache-dir).
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.