BUG: Raise ValueError on integer indexers containing NA; skip test for unsupported EAs #61441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_values_invalid_na_position
…t_values_with_missing
…xes\multi\test_setops.py
…into issue-shareMemory
…into issue-shareMemory
…into issue-shareMemory
…into issue-shareMemory
…into issue-shareMemory
pelagiavlas
force-pushed
the
issue-shareMemory
branch
from
84eb1d2 to
dfdf85c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.This PR addresses missing validation in
_setitem_with_indexer, where indexing with integer indexers containingpd.NA(e.g.,Int64arrays with missing values) would silently fail or misbehave.What this PR changes:
_setitem_with_indexerto raise aValueErrorwhen NA is present in the indexer.test_setitem_integer_with_missing_raisesto skip test cases for knownExtensionArraytypes (PeriodArray,DatetimeArray,IntervalArray) that do not support indexing with NA in integer indexers.