Skip to content

CLN Replace direct import of closing with qualified contextlib usage #61506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2025
Merged

CLN Replace direct import of closing with qualified contextlib usage #61506

merged 1 commit into from
May 27, 2025

Conversation

mheguy
Copy link
Contributor

@mheguy mheguy commented May 27, 2025

There were 4 uses of contextlib.closing and 2 of closing.

This PR converts the use of closing to contextlib.closing and removes the extra import statement.

@mroeschke mroeschke added the Testing pandas testing functions or related to the test suite label May 27, 2025
@mroeschke mroeschke added this to the 3.0 milestone May 27, 2025
@mroeschke mroeschke merged commit 97897e1 into pandas-dev:main May 27, 2025
48 checks passed
@mroeschke
Copy link
Member

Thanks @mheguy

@mheguy mheguy deleted the consistent-imports branch May 28, 2025 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees

No one assigned

Labels

Testing pandas testing functions or related to the test suite

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mheguy @mroeschke