CLN: Format comments in frame.py to comply with PEP8 line width #61547
+509
−394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for working on the proposed changes @TheCheerfulCoder. We validate in our CI that all rules from PEP-8 we care about are enforced. You can check the code checks jobs to get an idea all the things we validate. We're happy with these longer lines, and merging this PR means we lose the value that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! While becoming acquainted with the code, I noticed that the frame.py file had a lot of comments with a length over PEP8's 79 character limit.
I reformatted all comments to the 79 character limit, unless they involve command-line related code examples.
Let me know if there is anything I can do to help.
Thank you!