-
-
Notifications
You must be signed in to change notification settings - Fork 19.1k
DOC/ENH: Holiday exclusion argument #61600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
f054afb
5a809e2
891b442
aa08735
f019a5c
bdbb555
5bca8c7
655ca4e
f46c394
27cca3d
a9a745c
7710e43
5cfd599
2d9e4c5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -4,7 +4,10 @@ | |||||
datetime, | ||||||
timedelta, | ||||||
) | ||||||
from typing import TYPE_CHECKING | ||||||
from typing import ( | ||||||
TYPE_CHECKING, | ||||||
Any, | ||||||
) | ||||||
import warnings | ||||||
|
||||||
from dateutil.relativedelta import ( | ||||||
|
@@ -169,6 +172,7 @@ def __init__( | |||||
start_date=None, | ||||||
end_date=None, | ||||||
days_of_week: tuple | None = None, | ||||||
exclude_dates: list[Any] | None = None, | ||||||
|
exclude_dates: list[Any] | None = None, | |
exclude_dates: list[Timestamp] | None = None, |
Let's make the users do the Timestamp
conversion before passing into this object
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I also switch this to throw a ValueError
on failing? Or would that be a separate PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A separate PR would be better, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this, should I open a new issue? Or just make another PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just another PR is fine
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the constructor argument being stricter, we can just validate the arguments are all Timestamp
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Conversion to
DatetimeIndex
should be done in__init__
- Probably better to use
.difference
or releated method instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move this to
v3.0.0.rst
?