Skip to content

Conversation

hasanrashid
Copy link

Updated error message from
"Must have equal len keys and value when setting with an iterable"
to
f"Length mismatch when setting Dataframe with an iterable: " f"{len(pi)} keys vs {len(value)} values. " f"Keys: {pi}, Values: {value}. " f"Both must have the same length."

@hasanrashid
Copy link
Author

hasanrashid commented Jul 23, 2025

Actually, there are some failing test-indexing.py. Forgot to update the message in the testcase

@mroeschke mroeschke added the Error Reporting Incorrect or improved errors from pandas label Jul 23, 2025
@hunterhogan
Copy link

Thank you! I am sure this will make it much easier for me to figure out what I need to change!

@hasanrashid
Copy link
Author

Is there anything I need to do before this is reviewed?

@hasanrashid
Copy link
Author

Hi again folks. forks are synced and all tests passed. Will someone be able to review this PR?

@mroeschke
Copy link
Member

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

@mroeschke mroeschke closed this Oct 5, 2025
@hunterhogan
Copy link

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

  1. "Thanks, but." Adversative conjunction.
  2. "[Your] pull request [is] stale." WWWWWH:
    • Explicit information:
      • Hasan Rashid,
      • Hasan Rashid's pull request,
      • Hasan Rashid's pull request in pandas, and
      • after Hasan Rashid submitted Hasan Rashid's pull request.
    • Information for the reader to infer:
      • why and
      • how.
    • Ergo, why and how? Hasan Rashid.
  3. "... it appears ..."; 🚫 "Closed with unmerged commits." Disproportionate cause and effect.
  4. "... [you] merge, [you] address comments, and [you address] failing tests, and we can reopen." You must, you must, you must, and we might.
  5. "If you ..., we [might] ..." without explaining why repeating the same actions will lead to a different result two months from now.

I don't know @hasanrashid, and the only contact I've had with him is here in the pull request he donated to pandas. I don't speak for him, and I am not attempting to speak for him.

I am pointing out, for the umpteenth time, that pandas, Python, and the Python community are generally incompetent writers, which causes many problems that are willfully neglected, and that relatively easy changes to existing processes would have disproportionately great effects.


Hasan,

Thank you for your effort and your tenacity. I hope those virtues benefit you, your community, and the rest of us.

@mroeschke
Copy link
Member

I am pointing out, for the umpteenth time, that pandas, Python, and the Python community are generally incompetent writers

These types of generalizing critiques are not constructive (when describing any group of individuals), and while thank you for breaking down how my last comment could be interpreted as sufficiently unclear, I sense it also partially written to vent frustration like in this other comment. Please remember that open source communities are imperfect systems where largely volunteers, contributors and maintainers, develop software.

This pull request unfortunately slipped through the cracks from the maintainers and needed an update with the HEAD of the main branch. The team would still accept pull requests to fix the original issue, and an up-to-date pull request is more likely to be reviewed by a maintainer.

@hunterhogan
Copy link

These types of generalizing critiques are not constructive (when describing any group of individuals),

Not true. "pandas, Python, and the Python community are largely volunteers, contributors and maintainers developing software." See?

Please remember that open source communities are imperfect systems where largely volunteers, contributors and maintainers, develop software.

This is an excuse by those with power to maintain the status quo. When I volunteer to develop the writing in the software, I'm rejected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Error Reporting Incorrect or improved errors from pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: error message context.
3 participants