-
-
Notifications
You must be signed in to change notification settings - Fork 19.1k
BUG: Fix TypeError in assert_index_equal when comparing CategoricalIndex with check_categorical=True and exact=False #61941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mroeschke
merged 19 commits into
pandas-dev:main
from
Aniketsy:bugfix-assert-categoricalindex-typeerror
Oct 3, 2025
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
6871bd5
BUG: Fix TypeError in assert_index_equal when comparing CategoricalIn…
Aniketsy d637203
STYLE: Fix E501 line too long in assert_index_equal error message
Aniketsy 7a4aae6
TST: Add test case for categorical index assertion fix
Aniketsy 1a7c48c
BUG: Fix (GH#61941) and unit test
Aniketsy d600c06
Add unit test and (GH#61941)
Aniketsy eaeb094
Add unit test and (GH#61941)
Aniketsy 7037a72
Add unit test and (GH#61941)
Aniketsy 80aaf2c
TST: Fix formatting in test_assert_index_equal (via pre-commit)
Aniketsy 1a1ee91
style: fix formatting with pre-commit (Ruff)
Aniketsy 5419cf0
Fix: Check fail
Aniketsy db8006d
TST: Add test for CategoricalIndex vs Index in assert_index_equal
Aniketsy 2ba4cfb
TST: Use isinstance for CategoricalIndex in assert_index_equal
Aniketsy b82f867
Use the public .codes property for internal comparison of Categorical…
Aniketsy 9012972
TST: Add tests for CategoricalIndex mismatch scenarios
Aniketsy b99e6d2
BUG: assert_index_equal CategoricalIndex incomparable categories give…
Aniketsy 5d4af24
BUG: assert_index_equal CategoricalIndex incomparable categories give…
Aniketsy bc10d92
BUG: assert_index_equal CategoricalIndex incomparable categories give…
Aniketsy ac62aa5
Merge remote-tracking branch 'upstream/main' into bugfix-assert-categ…
Aniketsy 6ef5a73
Merge branch 'main' into bugfix-assert-categoricalindex-typeerror
Aniketsy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment pointing back to the original issue, otherwise ill be confused as to why this can happen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure , I will add comment